Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][WebSphere Application Server] Lens migration for visualizations to Kibana version 8.3.0 #5577

Closed
wants to merge 2 commits into from
Closed

[O11y][WebSphere Application Server] Lens migration for visualizations to Kibana version 8.3.0 #5577

wants to merge 2 commits into from

Conversation

rajvi-patel-22
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for WebSphere Application Server integration package

  • Statistics for WebSphere Application Server Lens migration:

WebSphere Application Server dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics WebSphere Application Server] Session Manager 4 1 4 0
[Metrics WebSphere Application Server] Servlet 3 0 3 0
[Metrics WebSphere Application Server] ThreadPool 6 1 6 0
[Metrics WebSphere Application Server] JDBC 4 1 4 0
  17 3 17 0
Note: Migrate 3 visualizations to new control panels.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 17, 2023 13:37
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 17, 2023
Closed
7 tasks
@kush-elastic kush-elastic added enhancement New feature or request v8.3.0 Team:Service-Integrations Label for the Service Integrations team Integration:websphere_application_server WebSphere Application Server labels Mar 17, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-17T13:38:52.596+0000

  • Duration: 27 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.432
Classes 100.0% (4/4) 💚 3.432
Methods 100.0% (28/28) 💚 8.84
Lines 100.0% (488/488) 💚 8.617
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor

@rajvi-elastic , Sharing a recommendation : to use colour theme as here
https://github.com/elastic/integrations/blob/db608ccfb0b13eb2c2ab94ceea297ade9648ad81/packages/oracle_weblogic/img/oracle_weblogic-logs-overview.png

The usage of themes / colours in a specific theme improve the UI consistency and also improve the dashboard readability

@rajvi-patel-22
Copy link
Contributor Author

@rajvi-elastic , Sharing a recommendation : to use colour theme as here https://github.com/elastic/integrations/blob/db608ccfb0b13eb2c2ab94ceea297ade9648ad81/packages/oracle_weblogic/img/oracle_weblogic-logs-overview.png

The usage of themes / colours in a specific theme improve the UI consistency and also improve the dashboard readability

Agreed @agithomas. The right color theme improves the dashboard readability and helps to highlight important data. But this PR only contains lens migration task and only three visualizations are migrated to new input controls. All the other panels are as it is. However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately.

@agithomas
Copy link
Contributor

However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately.

Understood. Please stick to the current scope.

@agithomas
Copy link
Contributor

Please create separate PRs for each dashboard / datastream.

@milan-elastic
Copy link
Contributor

Please create separate PRs for each dashboard / datastream.

@agithomas I understand there are 29 file changes showing, but If you see there are only 179 lines that are changed and most of them are because we exported in 8.3.0 and hence some necessary default properties are added.

FYI: Only 3 control panels are migrated to lens control panels, other visualizations are untouched as they were already in the lens. Let me know if you still want to raise the separate PR for each dashboard that contains 1 control panel change.

image

@agithomas
Copy link
Contributor

@agithomas I understand there are 29 file changes showing, but If you see there are only 179 lines that are changed and most of them are because we exported in 8.3.0 and hence some necessary default properties are added.

It is difficult to review the PR in current form and hence i request you to split PR - one per dashboard.

@rajvi-patel-22
Copy link
Contributor Author

@agithomas, As per the recommendation, created 3 other PRs data-stream wise for WebSphere Application Server. For that reason we are declining this PR. Let me know if you have any issues.

JDBC: #5631
Threadpool: #5632
Session Manager and Servlet: #5633

@agithomas
Copy link
Contributor

Please complete the peer review of the new PRs

@rajvi-patel-22
Copy link
Contributor Author

Closing this PR as we have raised separate PR for all the data-streams:
JDBC: #5631
Threadpool: #5632
Session Manager and Servlet: #5633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic Awaiting requested review from kush-elastic

@rameshelastic rameshelastic Awaiting requested review from rameshelastic

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

@agithomas agithomas Awaiting requested review from agithomas

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:websphere_application_server WebSphere Application Server Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @elasticmachine @agithomas @milan-elastic @kush-elastic